Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Add promise unit test #1173

Merged
merged 3 commits into from
May 13, 2022
Merged

test: Add promise unit test #1173

merged 3 commits into from
May 13, 2022

Conversation

egg-bread
Copy link
Contributor

This PR closes out #1053

KevinEady
KevinEady approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JckXia JckXia merged commit dc4f2bb into nodejs:main May 13, 2022
@JckXia
Copy link
Member

JckXia commented May 13, 2022

Landed as dc4f2bb

@JckXia JckXia mentioned this pull request May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinEady KevinEady KevinEady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egg-bread @JckXia @KevinEady